Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop http stats to sentry for dev builds #717

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Conversation

bigredfrog
Copy link
Contributor

@bigredfrog bigredfrog commented Feb 10, 2024

Summary by CodeRabbit

  • Refactor
    • Modified the sampling rate for error tracking to enhance performance and data accuracy.

Copy link
Contributor

coderabbitai bot commented Feb 10, 2024

Walkthrough

The recent update involves a modification in the Sentry configuration for error tracking within the project. Specifically, the change revolves around the adjustment of the sample_rate parameter. Previously, this rate was set to capture every event (1), but it has now been reduced to 0, effectively turning off event sampling. This alteration suggests a strategic shift in how the project approaches error logging and monitoring, possibly to reduce noise or focus on manually flagged issues.

Changes

File Summary of Changes
ledfx/sentry_config.py sample_rate changed from 1 to 0 with added commentary on the rationale behind this adjustment.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a4db9ba and 8acd8a1.
Files selected for processing (1)
  • ledfx/sentry_config.py (1 hunks)

Comment on lines +30 to +31
# Change sample_rate to 1 to look at http calls, so all rest traffic stats
sample_rate = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 30 is misleading. It suggests changing sample_rate to 1 to monitor HTTP calls, but the actual change sets it to 0. This could confuse future maintainers. Consider updating the comment to accurately reflect the change and its purpose.

-    # Change sample_rate to 1 to look at http calls, so all rest traffic stats
+    # Set sample_rate to 0 to stop sending HTTP statistics to Sentry for development builds

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
# Change sample_rate to 1 to look at http calls, so all rest traffic stats
sample_rate = 0
# Set sample_rate to 0 to stop sending HTTP statistics to Sentry for development builds
sample_rate = 0

@shauneccles shauneccles merged commit d18d477 into LedFx:main Feb 10, 2024
20 checks passed
@bigredfrog bigredfrog deleted the sentry6 branch February 11, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants