-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop http stats to sentry for dev builds #717
Conversation
WalkthroughThe recent update involves a modification in the Sentry configuration for error tracking within the project. Specifically, the change revolves around the adjustment of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Change sample_rate to 1 to look at http calls, so all rest traffic stats | ||
sample_rate = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 30 is misleading. It suggests changing sample_rate
to 1 to monitor HTTP calls, but the actual change sets it to 0. This could confuse future maintainers. Consider updating the comment to accurately reflect the change and its purpose.
- # Change sample_rate to 1 to look at http calls, so all rest traffic stats
+ # Set sample_rate to 0 to stop sending HTTP statistics to Sentry for development builds
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
# Change sample_rate to 1 to look at http calls, so all rest traffic stats | |
sample_rate = 0 | |
# Set sample_rate to 0 to stop sending HTTP statistics to Sentry for development builds | |
sample_rate = 0 |
Summary by CodeRabbit