Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile rework + fix guidelines enforcer errors #44

Merged
merged 2 commits into from
May 23, 2023

Conversation

apaillier-ledger
Copy link
Contributor

No description provided.

@apaillier-ledger apaillier-ledger force-pushed the fix/apa/guidelines_enforcer branch 3 times, most recently from 2730615 to aab69e6 Compare May 23, 2023 08:54
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/guidelines_enforcer branch 3 times, most recently from 0c4c815 to 07d9818 Compare May 23, 2023 15:27
@apaillier-ledger apaillier-ledger changed the title Fix guidelines enforcer errors Makefile rework + fix guidelines enforcer errors May 23, 2023
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much does it change the generated binary?

@apaillier-ledger
Copy link
Contributor Author

How much does it change the generated binary?

No change in the checksum of the resulting bin/app.hex

@xchapron-ledger
Copy link
Contributor

How much does it change the generated binary?

No change in the checksum of the resulting bin/app.hex

Then what are we waiting for a merge!

- Changed plugin boilerplate default variant & appname
- Renamed app icons
- Gets icon name from APPNAME
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/guidelines_enforcer branch 2 times, most recently from bc3783c to addb2e8 Compare May 23, 2023 16:37
@apaillier-ledger apaillier-ledger merged commit 03cb5ab into develop May 23, 2023
@fbeutin-ledger fbeutin-ledger deleted the fix/apa/guidelines_enforcer branch October 31, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants