Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error on Ledger Blue checkGenuine #47

Closed
hantuzun opened this issue Aug 16, 2018 · 2 comments
Closed

Syntax error on Ledger Blue checkGenuine #47

hantuzun opened this issue Aug 16, 2018 · 2 comments

Comments

@hantuzun
Copy link

I plug my Ledger Blue device and checkGenuine` with the following command:

$ python -m ledgerblue.checkGenuine --targetId 0x31010004

It returns the following error:

Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/lib/python2.7/dist-packages/ledgerblue/checkGenuine.py", line 140, in <module>
    secret = getDeployedSecretV2(dongle, bytearray.fromhex(args.rootPrivateKey), args.targetId, args.issuerKey)
  File "/usr/local/lib/python2.7/dist-packages/ledgerblue/checkGenuine.py", line 110, in getDeployedSecretV2
    return ret
UnboundLocalError: local variable 'ret' referenced before assignment

That's due to an indentation error introduced in e834117#diff-a38efbe7c6ced1dae1d585bace6a8da0R110

I'll be fixing this with a PR soon.

hantuzun added a commit to HardAgency/blue-loader-python that referenced this issue Aug 16, 2018
Fixes LedgerHQ#47 (Syntax error on Ledger Blue checkGenuine)
@hantuzun
Copy link
Author

Hi Nicolas (@btchip), kindly review this issue.

@btchip
Copy link
Contributor

btchip commented Sep 4, 2018

Thanks, will be fixed in 0.1.20

@btchip btchip closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants