Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Fixes LL-3059 #813

Merged
merged 1 commit into from Aug 13, 2020
Merged

Fixes LL-3059 #813

merged 1 commit into from Aug 13, 2020

Conversation

gre
Copy link
Contributor

@gre gre commented Aug 10, 2020

  • This implements cashaddr for BCH accounts as described in LL-2806
  • Add AccountBridge#receive : LLD and LLM needs to use it instead of getAddress for receive flow because it will properly display a cash address

@vercel
Copy link

vercel bot commented Aug 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/gk8nby97l
✅ Preview: https://ledger-live-common-git-ll-3059.ledgerhq.vercel.app

@gre gre added the HODL label Aug 10, 2020
gre added a commit to gre/ledger-live-desktop that referenced this pull request Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #813 into master will increase coverage by 13.66%.
The diff coverage is 79.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #813       +/-   ##
===========================================
+ Coverage   51.98%   65.64%   +13.66%     
===========================================
  Files         231      264       +33     
  Lines        8799     8698      -101     
  Branches     1885     1854       -31     
===========================================
+ Hits         4574     5710     +1136     
+ Misses       3237     2375      -862     
+ Partials      988      613      -375     
Impacted Files Coverage Δ
src/families/bitcoin/account.js 6.25% <0.00%> (-93.75%) ⬇️
src/families/tezos/libcore-buildSubAccounts.js 2.70% <ø> (ø)
src/libcore/buildAccount/index.js 98.57% <ø> (ø)
src/bridge/jsHelpers.js 81.17% <14.28%> (+76.04%) ⬆️
src/families/bitcoin/bridge/libcore.js 88.05% <25.00%> (-4.01%) ⬇️
src/bridge/mockHelpers.js 95.45% <50.00%> (+84.98%) ⬆️
src/families/bitcoin/transaction.js 66.66% <75.00%> (-28.93%) ⬇️
src/families/bitcoin/libcore-postBuildAccount.js 94.73% <90.90%> (-5.27%) ⬇️
src/families/bitcoin/bridge/mock.js 96.87% <100.00%> (+71.06%) ⬆️
src/families/bitcoin/hw-getAddress.js 75.00% <100.00%> (ø)
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482e37d...bf0a43d. Read the comment docs.

- This implements cashaddr for BCH accounts as described in LL-2806
- Add AccountBridge#receive : LLD and LLM needs to use it instead of getAddress for receive flow because it will properly display a cash address
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant