This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
Fixes LL-3059 #813
Merged
Fixes LL-3059 #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gre
commented
Aug 10, 2020
•
edited
edited
- This implements cashaddr for BCH accounts as described in LL-2806
- Add AccountBridge#receive : LLD and LLM needs to use it instead of getAddress for receive flow because it will properly display a cash address
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/gk8nby97l |
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
===========================================
+ Coverage 51.98% 65.64% +13.66%
===========================================
Files 231 264 +33
Lines 8799 8698 -101
Branches 1885 1854 -31
===========================================
+ Hits 4574 5710 +1136
+ Misses 3237 2375 -862
+ Partials 988 613 -375
Continue to review full report at Codecov.
|
- This implements cashaddr for BCH accounts as described in LL-2806 - Add AccountBridge#receive : LLD and LLM needs to use it instead of getAddress for receive flow because it will properly display a cash address
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.