Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Switch BCH address formatting to cashaddr #3120

Merged
merged 1 commit into from Aug 13, 2020
Merged

Conversation

gre
Copy link
Contributor

@gre gre commented Aug 13, 2020

Fixes #980
depends on LedgerHQ/ledger-live-common#813

Type

feature

Context

LL-2806

Parts of the app affected / Test plan

  • all existing bch accounts will be formatting the address as cashaddr. However, a synchronisation will be required in order for the account to update that state, receive flow might temporarily tell "something wrong happened" if the sync is not waited, it's a limited tradeoff here.
  • when the sync is complete, it is expected that all operations will have their inputs, outputs formatted as cashaddr
  • it is also expected that a Receive will correctly format the device as cashaddr and the UI as well.
  • the cashaddr format chosen do not includes the bitcoincash: prefix because the device didn't. It also makes things more concise, cashaddr spec clearly says that this can be omitted by wallets.
  • the impact of live-common needs to be taken into consideration as all Receive flow has been reworked to allow the bridge to expose a custom receive. It also impact the Buy Crypto as it's also doing a receive.
  • It is recommended to QA this PR first so we can know if we can merge the live-common PR and do a bump there, before merging this current PR.

@gre gre added important label used to flag a PR as important to be merged in priority (sometimes because dependencies) HODL for PRs: this is blocked, we can't merge yet QA labels Aug 13, 2020
@github-actions
Copy link

PR to merge LL-2806 797873e -> develop

Diff output







Please download attached snapshots.zip, extract it in folder and update your PR with it

@Arnaud97234 Arnaud97234 self-assigned this Aug 13, 2020
@Arnaud97234 Arnaud97234 self-requested a review August 13, 2020 16:04
@gre
Copy link
Contributor Author

gre commented Aug 13, 2020

as it passed QA, i'll merge this now otherwise it's going to collide with incoming PRs =)

@gre gre merged commit 9c2f4e0 into LedgerHQ:develop Aug 13, 2020
@gre
Copy link
Contributor Author

gre commented Aug 13, 2020

@chaintip fixes #980

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
HODL for PRs: this is blocked, we can't merge yet important label used to flag a PR as important to be merged in priority (sometimes because dependencies) QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cashaddr format for Bitcoin Cash
2 participants