This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Add accounts feedback #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meriadec
force-pushed
the
add-accounts-feedback
branch
from
df5e036
to
9e2d879
Compare
gre
previously approved these changes
Nov 3, 2018
|
I think it can be merged |
|
conflict resolved |
gre
approved these changes
Nov 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the polish we put default padding to BottomModal, so there is risk that it can affect other modals (we'll pixel push them later). The goal is to limit at maximum the styling specificity.
HODL for now, waiting for the libcore fix.