Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(Languages): Inconsistency in languages display names #1309

Merged
merged 1 commit into from Sep 20, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 19, 2022

πŸ“ Description

Inconsistency in languages display names

❓ Context

  • Impacted projects: live-mobile live-desktop
  • Linked resource(s): LIVE-3651

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Go to Settings > General > Language
Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 19, 2022 at 1:11PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 19, 2022 at 1:11PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 19, 2022 at 1:11PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 19, 2022 at 1:11PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

πŸ¦‹ Changeset detected

Latest commit: 04fb3f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
ledger-live-desktop Patch
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD mobile Has changes in LLM labels Sep 19, 2022
@github-actions
Copy link

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit f2ac581 into develop Sep 20, 2022
@LFBarreto LFBarreto deleted the bugfix/llm-lld-languages-display branch September 20, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants