Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(Languages): Inconsistency in languages display names #1309

Merged
merged 1 commit into from
Sep 20, 2022
Merged

bugfix(Languages): Inconsistency in languages display names #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/honest-games-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"ledger-live-desktop": patch
"live-mobile": patch
---

Inconsistency in languages display names
14 changes: 7 additions & 7 deletions apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/LanguageSelect.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@ export const languageLabels = {
el: "Ελληνικά",
en: "English",
es: "Español",
fi: "suomi",
fi: "Suomi",
fr: "Français",
hu: "magyar",
it: "italiano",
hu: "Magyar",
it: "Italiano",
ja: "日本語",
ko: "한국어",
nl: "Nederlands",
no: "Norsk",
pl: "polski",
pt: "português",
pl: "Polski",
pt: "Português",
ru: "Русский",
sr: "српски",
sv: "svenska",
sr: "Cрпски",
sv: "Svenska",
tr: "Türkçe",
zh: "简体中文",
};
Expand Down
12 changes: 6 additions & 6 deletions apps/ledger-live-mobile/src/languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ export const languages = {
el: "Ελληνικά",
en: "English",
es: "Español",
fi: "suomi",
fi: "Suomi",
fr: "Français",
hu: "magyar",
it: "italiano",
hu: "Magyar",
it: "Italiano",
ja: "日本語",
ko: "한국어",
nl: "Nederlands",
no: "Norsk",
pl: "polski",
pl: "Polski",
pt: "Português",
ru: "Русский",
sr: "српски",
sv: "svenska",
sr: "Cрпски",
sv: "Svenska",
tr: "Türkçe",
zh: "简体中文",
};
Expand Down
25 changes: 2 additions & 23 deletions apps/ledger-live-mobile/src/screens/Settings/General/LanguageRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,7 @@ import { Text } from "@ledgerhq/native-ui";
import SettingsRow from "../../../components/SettingsRow";
import { ScreenName } from "../../../const";
import { useLocale } from "../../../context/Locale";

export const languageLabels = {
de: "Deutsch",
el: "Ελληνικά",
en: "English",
es: "Español",
fi: "suomi",
fr: "Français",
hu: "magyar",
it: "italiano",
ja: "日本語",
ko: "한국어",
nl: "Nederlands",
no: "Norsk",
pl: "polski",
pt: "português",
ru: "Русский",
sr: "српски",
sv: "svenska",
tr: "Türkçe",
zh: "简体中文",
};
import { languages } from "../../../languages";

const LanguageSettingsRow = () => {
const { locale } = useLocale();
Expand All @@ -46,7 +25,7 @@ const LanguageSettingsRow = () => {
onPress={onNavigate}
>
<Text variant={"body"} fontWeight={"medium"} color="primary.c80">
{languageLabels[locale] || locale}
{languages[locale] || locale}
</Text>
</SettingsRow>
);
Expand Down