-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLD: Fully sunset "internal commands" + remove tech debt & dead code #2859
Conversation
🦋 Changeset detectedLatest commit: 3ee4e3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d73c0f4
to
a3e1342
Compare
a3e1342
to
977f492
Compare
977f492
to
25f5138
Compare
25f5138
to
1ae7fe7
Compare
1ae7fe7
to
999ee29
Compare
999ee29
to
1b3db3a
Compare
1b3db3a
to
28f6045
Compare
28f6045
to
7e01d1b
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #2859 +/- ##
============================================
- Coverage 89.91% 65.34% -24.58%
============================================
Files 26 85 +59
Lines 1289 5041 +3752
Branches 259 973 +714
============================================
+ Hits 1159 3294 +2135
- Misses 125 1635 +1510
- Partials 5 112 +107
Flags with carried forward coverage won't be shown. Click here to find out more. see 59 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
7e01d1b
to
0b83440
Compare
0b83440
to
648f2f6
Compare
648f2f6
to
8bc7ef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment/question, I still need to look at the rest of the files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like it's just removing applyReconciliation on our part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments/questions but LGTM
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!!!!!!
Have we implemented something to prevent import in the "global" way? If not, could we implemented it?
I think no-restricted-import
could help...
import-js/eslint-plugin-import#810
@sarneijim i'm going to note this as part of the bundle size optim we need to schedule on |
3ee4e3b
to
d12df9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📝 Description
This PR ships another step in simplifying main/internal scripts and making internal process even more minimal (sunset of commands, only remains the transport).
Clean up related to internal process
AccountBridge#applyReconciliation
is therefore dropped.introduce Web Workers
secp256k1
Bitcoin elliptic curve is executed in a web worker (publicKeyTweakAdd
). with some parallel web worker to allow even faster parallel derivations.general libraries and other code clean up
❓ Context
LLD
✅ Checklist
📸 Demo
no demo. negative coding 😆
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.