Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/LIVE 11608 llm swap wrong behaviour with the drawer #6388

Merged
merged 3 commits into from
Mar 7, 2024
Merged

bugfix/LIVE 11608 llm swap wrong behaviour with the drawer #6388

merged 3 commits into from
Mar 7, 2024

Conversation

cng-ledger
Copy link
Contributor

@cng-ledger cng-ledger commented Mar 6, 2024 •
edited
Loading

📝 Description

  • Make sure LLM quote refresh rate is 60 seconds
  • Disable quote refresh during modal shown for confirmation

❓ Context

  • JIRA or GitHub link:

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 6:21pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 6:21pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 6:21pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 6:21pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 6:21pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched cli labels Mar 6, 2024
@cng-ledger cng-ledger changed the base branch from develop to release March 6, 2024 17:50
@cng-ledger cng-ledger force-pushed the bugfix/LIVE-11608-llm-swap-wrong-behaviour-with-the-drawer branch from b7be3de to 12815e5 Compare March 6, 2024 18:05
@cng-ledger cng-ledger marked this pull request as ready for review March 6, 2024 18:05
@cng-ledger cng-ledger requested a review from a team as a code owner March 6, 2024 18:05
@live-github-bot live-github-bot bot removed desktop Has changes in LLD ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched cli labels Mar 6, 2024
@cng-ledger cng-ledger merged commit b5e2c2c into release Mar 7, 2024
57 checks passed
@cng-ledger cng-ledger deleted the bugfix/LIVE-11608-llm-swap-wrong-behaviour-with-the-drawer branch March 7, 2024 08:05
@cng-ledger cng-ledger mentioned this pull request Mar 15, 2024
Merged
9 tasks
KVNLS pushed a commit that referenced this pull request Mar 21, 2024
@cng-ledger @KVNLS
bugfix/LIVE 11608 llm swap wrong behaviour with the drawer (#6388)
b87d3a7 
* fix(LIVE-11382): disable refresh during confirmation

* fix(LIVE-11382): changeset

* fix(LIVE-11382): lint
cng-ledger added a commit that referenced this pull request Mar 21, 2024
@cng-ledger
bugfix/LIVE 11608 llm swap wrong behaviour with the drawer (#6388)
bed2f16 
* fix(LIVE-11382): disable refresh during confirmation

* fix(LIVE-11382): changeset

* fix(LIVE-11382): lint
cng-ledger added a commit that referenced this pull request Mar 26, 2024
@cng-ledger
bugfix/LIVE 11608 llm swap wrong behaviour with the drawer (#6510)
13293e8 
* bugfix(LIVE-11608): llm swap wrong behaviour with the drawer (#6377)

* fix(LIVE-11608): different quote refresh rate for LLM

* fix(LIVE-11382): changeset

* bugfix/LIVE 11608 llm swap wrong behaviour with the drawer (#6388)

* fix(LIVE-11382): disable refresh during confirmation

* fix(LIVE-11382): changeset

* fix(LIVE-11382): lint

* fix(LIVE-11608): lint

* fix(LIVE-11608): remove unused vars from LLD

* fix(LIVE-11608): desktop lint
KVNLS pushed a commit that referenced this pull request Mar 27, 2024
@cng-ledger @KVNLS
bugfix/LIVE 11608 llm swap wrong behaviour with the drawer (#6388)
7f1d4ec 
* fix(LIVE-11382): disable refresh during confirmation

* fix(LIVE-11382): changeset

* fix(LIVE-11382): lint
KVNLS pushed a commit that referenced this pull request Mar 27, 2024
@cng-ledger @KVNLS
bugfix/LIVE 11608 llm swap wrong behaviour with the drawer (#6388)
63504be 
* fix(LIVE-11382): disable refresh during confirmation

* fix(LIVE-11382): changeset

* fix(LIVE-11382): lint
KVNLS pushed a commit that referenced this pull request Mar 28, 2024
@cng-ledger @KVNLS
bugfix/LIVE 11608 llm swap wrong behaviour with the drawer (#6388)
1d4ab90 
* fix(LIVE-11382): disable refresh during confirmation

* fix(LIVE-11382): changeset

* fix(LIVE-11382): lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallen-ledger kallen-ledger kallen-ledger approved these changes

Assignees

@cng-ledger cng-ledger

Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cng-ledger @kallen-ledger