Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LIVE 11791 swap llm expected usdt does not change #6451

Merged

Conversation

cng-ledger
Copy link
Contributor

@cng-ledger cng-ledger commented Mar 15, 2024

πŸ“ Description

Update redux exchange rate using rates from navigation params

❓ Context

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cng-ledger cng-ledger requested review from a team as code owners March 15, 2024 13:26
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Mar 19, 2024 11:50am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 11:50am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 11:50am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 11:50am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 11:50am

@cng-ledger cng-ledger changed the base branch from develop to release March 15, 2024 13:26
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched cli labels Mar 15, 2024
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Mar 15, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0πŸ”‘

@cng-ledger cng-ledger force-pushed the bugfix/LIVE-11791-swap-llm-expected-usdt-does-not-change branch from 7afc11a to 574d3f6 Compare March 15, 2024 13:29
@live-github-bot live-github-bot bot removed desktop Has changes in LLD translations Translation files have been touched cli labels Mar 15, 2024
Justkant
Justkant previously approved these changes Mar 15, 2024
Base automatically changed from release to main March 18, 2024 17:27
@mcayuelas-ledger mcayuelas-ledger dismissed Justkant’s stale review March 18, 2024 17:27

The base branch was changed.

@cng-ledger cng-ledger changed the base branch from main to develop March 18, 2024 20:48
@cng-ledger cng-ledger force-pushed the bugfix/LIVE-11791-swap-llm-expected-usdt-does-not-change branch from e63b207 to 543a1bd Compare March 18, 2024 20:54
@live-github-bot live-github-bot bot added the common Has changes in live-common label Mar 19, 2024
CremaFR
CremaFR previously approved these changes Mar 19, 2024
Justkant
Justkant previously approved these changes Mar 19, 2024
Justkant
Justkant previously approved these changes Mar 19, 2024
rates: availableRates,
});
break;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor nitpick/opinion]: It might be nice to have an explicit default here, if we're using a switch...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@cng-ledger cng-ledger merged commit 0c9c70e into develop Mar 19, 2024
37 of 38 checks passed
@cng-ledger cng-ledger deleted the bugfix/LIVE-11791-swap-llm-expected-usdt-does-not-change branch March 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants