-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/live 9301 infinite loader #6394
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
@@ -413,6 +415,15 @@ export const DeviceActionDefaultRendering = <R, H extends States, P>({ | |||
}); | |||
} | |||
|
|||
if (unresponsive || error instanceof TransportRaceCondition) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Comment] Not relate to your PR but what a generic name for an error TransportRaceCondition
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thoughts 😅 we should maybe rename it like TransportPendingOperation
. It would be more clear and less weird
d2b248a
apps/ledger-live-desktop/src/renderer/components/DeviceAction/index.tsx
Outdated
Show resolved
Hide resolved
d2b248a
to
0c5a47c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for Hub team scope :)
This event can occur with event implementation when an action is pending on the device and another command is sent
e250902
to
931d511
Compare
hey @aussedatlo this is a breaking change, not in line with semver Can we bring |
@devfive you are not part of the organization, please contact a maintainer if you need to run this command. |
3 similar comments
@devfive you are not part of the organization, please contact a maintainer if you need to run this command. |
@devfive you are not part of the organization, please contact a maintainer if you need to run this command. |
@devfive you are not part of the organization, please contact a maintainer if you need to run this command. |
📝 Description
In a case where the device is waiting for a user prompt (for example open Ethereum app)
The device action can result in an infinite loader because the unresponsive state of the device is not handled correctly.
Before:
LIVE-99301-before.mov
After:
LIVE-9301-after.mov
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.🧐 Checklist for the PR Reviewers