Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add segwit tests #854

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Add segwit tests #854

merged 3 commits into from
Feb 17, 2022

Conversation

viktorb-ledger
Copy link
Contributor

@viktorb-ledger viktorb-ledger commented Feb 15, 2022 •
edited
Loading

  • Adds CreateTransaction tests with P2WPKH and P2WSH outputs.
  • Removes BitcoinLikeTransactionBuilder::addInput method (not used, probably incorrectly implemented).
  • Fixes Tezos tests that require stable account id.

@viktorb-ledger viktorb-ledger marked this pull request as ready for review February 16, 2022 08:19
@viktorb-ledger
Copy link
Contributor Author

For all tests to pass this PR needs #853

jcoatelen-ledger
jcoatelen-ledger approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@jcoatelen-ledger jcoatelen-ledger merged commit 6b441d3 into release/4.1.0 Feb 17, 2022
@jcoatelen-ledger jcoatelen-ledger deleted the test_segwit branch February 17, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoatelen-ledger jcoatelen-ledger jcoatelen-ledger approved these changes

@twilgenbus-ledger twilgenbus-ledger Awaiting requested review from twilgenbus-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktorb-ledger @jcoatelen-ledger