Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poc of interface guiding user to physical device instructions #76

Merged
merged 9 commits into from
May 12, 2023
Merged

Poc of interface guiding user to physical device instructions #76

merged 9 commits into from
May 12, 2023

Conversation

lpascal-ledger
Copy link
Contributor

@lpascal-ledger lpascal-ledger commented Jan 4, 2023 •
edited
Loading

Testable with boilerplate application, for instance (on nanos):

pytest tests/test_pubkey_cmd.py -k get_public_key_confirm --device nanos --backend ledgercomm --tb=short

@fbeutin-ledger fbeutin-ledger mentioned this pull request Jan 4, 2023
Closed
@lpascal-ledger lpascal-ledger changed the title [tmp] First poc [tmp] Poc of interface guiding user to physical device instructions Jan 4, 2023
@lpascal-ledger lpascal-ledger changed the title [tmp] Poc of interface guiding user to physical device instructions Poc of interface guiding user to physical device instructions Jan 4, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2023
View reviewed changes
src/ragger/gui/__init__.py Fixed Show fixed Hide fixed
src/ragger/backend/ledgerwallet.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2023
View reviewed changes
src/ragger/gui/process.py Fixed Show fixed Hide fixed
src/ragger/backend/physical_backend.py Fixed Show fixed Hide fixed
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023 •
edited
Loading

Codecov Report

Base: 92.50% // Head: 83.40% // Decreases project coverage by -9.10% ⚠️

Coverage data is based on head (7a9eb22) compared to base (85fcc1b).
Patch coverage: 42.22% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    92.50%   83.40%   -9.11%     
===========================================
  Files           27       31       +4     
  Lines          961     1139     +178     
===========================================
+ Hits           889      950      +61     
- Misses          72      189     +117
Impacted Files Coverage Δ
src/ragger/backend/__init__.py 37.50% <0.00%> (-12.50%) ⬇️
src/ragger/gui/interface.py 29.41% <29.41%> (ø)
src/ragger/gui/process.py 35.61% <35.61%> (ø)
src/ragger/backend/physical_backend.py 67.44% <67.44%> (ø)
src/ragger/backend/ledgercomm.py 100.00% <100.00%> (+7.24%) ⬆️
src/ragger/backend/ledgerwallet.py 94.64% <100.00%> (+5.60%) ⬆️
src/ragger/gui/__init__.py 100.00% <100.00%> (ø)
src/ragger/logger.py 88.23% <100.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch 4 times, most recently from bda33b7 to 5126954 Compare January 5, 2023 09:08
@xchapron-ledger xchapron-ledger mentioned this pull request Jan 9, 2023
Closed
@agrojean-ledger agrojean-ledger force-pushed the lp/physical_backend_navigation branch 3 times, most recently from 8e4a3c8 to fc99423 Compare February 8, 2023 17:05
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-advanced-security[bot]
github-advanced-security bot found potential problems May 9, 2023
View reviewed changes
src/ragger/backend/physical_backend.py
def __exit__(self, exc_type: Optional[Type[BaseException]], exc_val: Optional[BaseException],
exc_tb: Optional[TracebackType]):

Check notice

Code scanning / CodeQL

Mismatch between signature and use of an overridden method

Overridden method signature does not match [call](1), where it is passed too few arguments. Overriding method [method LedgerCommBackend.__exit__](2) matches the call. Overridden method signature does not match [call](3), where it is passed too few arguments. Overriding method [method LedgerWalletBackend.__exit__](4) matches the call.
@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch 6 times, most recently from 8af5982 to c8bede3 Compare May 9, 2023 14:57
@lpascal-ledger lpascal-ledger marked this pull request as ready for review May 9, 2023 15:05
xchapron-ledger
xchapron-ledger reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the gui code but that looks promising, I need to take some time testing this!

src/ragger/navigator/__init__.py Show resolved Hide resolved
@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch from 6505e37 to fcf38ea Compare May 9, 2023 16:34
@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch from fcf38ea to 6098ba6 Compare May 9, 2023 16:39
@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch from 6098ba6 to 7cdee75 Compare May 9, 2023 16:40
@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch from 97e2f86 to c36c763 Compare May 12, 2023 14:16
@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch from c36c763 to 6ab4411 Compare May 12, 2023 14:19
@lpascal-ledger lpascal-ledger force-pushed the lp/physical_backend_navigation branch from 3ea381c to f428f45 Compare May 12, 2023 15:07
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@lpascal-ledger lpascal-ledger merged commit bb8d788 into develop May 12, 2023
@lpascal-ledger lpascal-ledger deleted the lp/physical_backend_navigation branch May 12, 2023 15:25
@lpascal-ledger lpascal-ledger mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger left review comments

@fbeutin-ledger fbeutin-ledger Awaiting requested review from fbeutin-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpascal-ledger @codecov-commenter @xchapron-ledger @agrojean-ledger