Fix Default Provider for Bitcoin #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meriadec
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Hey @glethuillier :)
kinda blindly approved as there is multiple things mixed in PR (GitHub actions, dependencies update (also a bit concerning that we seem to use both a yarn.lock and an npm-shrinkwrap.json), and various typing/logic changes, so it's kinda hard to understand the PR substance (but I trust you :D)
Anyway, safe to merge for us (LES) as AFAIK it's now not anymore used in the stack.
Added a minor comment
meriadec
reviewed
Jun 8, 2023
meriadec
reviewed
Jun 8, 2023
meriadec
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, the default provider for Bitcoin is no longer operating as it should.
This update changes the default provider to fix this behavior.
Note: other protocols (Bitcoin Cash for instance) should be addressed by another PR.