Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI Linux automatic builds #101

Merged
merged 11 commits into from Jun 26, 2018
Merged

CircleCI Linux automatic builds #101

merged 11 commits into from Jun 26, 2018

Conversation

DanielUranga
Copy link
Member

Initial CircleCI support. Builds using Ubuntu Linux 18.04.
Build log here: https://circleci.com/gh/DanielUranga/lc0/10
This is an attempt to start solving #50

@DanielUranga
Copy link
Member Author

Example lc0 Ubuntu 18.04 autogenerated binary: https://15-138075467-gh.circle-artifacts.com/0/lc0-ubuntu-18-04

@DanielUranga
Copy link
Member Author

I think this is ready to merge now. It builds using both g++ and clang with every dependency but "Accelerate" and uploads the generated binaries.

@DanielUranga DanielUranga changed the title Initial CircleCI support CircleCI Linux automatic builds Jun 23, 2018
Copy link
Member

@mooskagh mooskagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what's all that about, but as that's in a separate directory, fine to merge.

@dubslow
Copy link
Member

dubslow commented Jun 23, 2018

I'll take a closer look then and merge it within a day or two.

Here are some binaries, for reference:

[3:05 PM] fersbery: builds using both g++ and clang, and uploads both binaries
[3:06 PM] fersbery: https://24-138075467-gh.circle-artifacts.com/0/lc0-ubuntu-18-04-clang
[3:06 PM] fersbery: and
[3:06 PM] fersbery: https://24-138075467-gh.circle-artifacts.com/0/lc0-ubuntu-18-04-g%2B%2B

@DanielUranga
Copy link
Member Author

After this gets merged, the Leela organization will need to create an account on CircleCI and configure it for automatic builds (can be configured for every branch and for PRs), and it is possible to also display status badges.

@DanielUranga
Copy link
Member Author

Also it should be possible to use something like Ghr (https://github.com/tcnksm/ghr) to automatically upload Github releases.

@mooskagh
Copy link
Member

@DanielUranga I'm not sure how that works in github, but I think that after PR has an approval, you should have "Merge" button available. If you don't have that, I can merge. (also it would be nice to know whether it's indeed to)

@DanielUranga
Copy link
Member Author

Nope, I can't merge: Only those with write access to this repository can merge pull requests.

@mooskagh mooskagh merged commit 2e8a62a into LeelaChessZero:master Jun 26, 2018
@DanielUranga DanielUranga deleted the CircleCI branch June 27, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants