make uci search parameters the defaults ones #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooskagh
approved these changes
Dec 24, 2018
mooskagh
reviewed
Dec 24, 2018
src/benchmark/benchmark.cc
Outdated
| @@ -60,7 +60,8 @@ void Benchmark::Run() { | |||
|
|
|||
| defaults->Set<int>(SearchParams::kMiniBatchSizeId.GetId(), 256); | |||
| defaults->Set<float>(SearchParams::kFpuReductionId.GetId(), 1.2f); | |||
| defaults->Set<float>(SearchParams::kCpuctId.GetId(), 3.4f); | |||
| defaults->Set<float>(SearchParams::kCpuctId.GetId(), 3.0f); | |||
There was a problem hiding this comment.
Maybe make those defaults and override in selfplay?
There was a problem hiding this comment.
Why not a helper function in SearchParams that changes the defaults?
borg323
changed the title
|
In the end I decided that it is better for all search parameters to default to the uci values with overrides for selfplay only. |
mooskagh
approved these changes
Dec 26, 2018
borg323
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.