Cudnn update to 7.4.2 + warn if old version is used with RTX cards #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankan-ban
approved these changes
Feb 18, 2019
src/neural/cuda/network_cudnn.cc
Outdated
| "version " | ||
| << CUDNN_MAJOR << "." << CUDNN_MINOR << "." << CUDNN_PATCHLEVEL; | ||
| } | ||
| if (version < 7301 && (deviceProp.major > 7 || | ||
| (deviceProp.major == 7 && deviceProp.minor > 5))) { |
There was a problem hiding this comment.
Turing (RTX 20xx cards) is 7.5, so you need minor version greater or equal to 5. i.e:
(deviceProp.major == 7 && deviceProp.minor => 5)
mooskagh
approved these changes
Feb 24, 2019
|
The RC binaries seem to give a warning because they're compiled with 7.3.1 and they detect a mismatch with the shipped version. |
|
Is this downloading just the executable? Probably appveyor is still using a cached version but the packaged zip should be OK. |
|
The packaged zip of the 0.20.2 release actually ships with 7.3.1 instead of 7.4.2 so it won't give the error, but I doubt that was the intention? |
|
Updating the appveyor cache is a hassle, so I avoid it as much as I can. There is no urgency to move to 7.4.2, so I didn't force the update: It usually happens frequently enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.