Antus/p04 osids (#290)

* Update list of currently known P04 OSIDs. Reword P04 warnings. * Allow 1K packets on all STN devices, including ones we have not seen before. --------- Co-authored-by: antus <antus@pcmhacking.net>
LegacyNsfw · Apr 10, 2023 · ad03d40 · ad03d40
1 parent 62856c2
commit ad03d40
Show file tree

Hide file tree

Showing 3 changed files with 1,237 additions and 23 deletions.
diff --git a/Apps/PcmHammer/MainForm.cs b/Apps/PcmHammer/MainForm.cs
@@ -819,10 +819,9 @@ private async void readPropertiesButton_Click(object sender, EventArgs e)
                     if (pcmInfo.HardwareType == PcmType.P04)
                     {
                         this.AddUserMessage("**********************************************");
-                        this.AddUserMessage("WARNING: P04 Read is EXPERIMENTAL ONLY.");
-                        this.AddUserMessage("It may or may not read your P04 correctly. The read will be VERY SLOW.");
-                        this.AddUserMessage("If you have the skills please help us improve this code and send us a pull request on github.");
-                        this.AddUserMessage("P04 Write is not yet under development, please do not ask when it is ready. P04 read must work well first.");
+                        this.AddUserMessage("WARNING: P04 Support is still in development.");
+                        this.AddUserMessage("It may or may not read your P04 correctly.");
+                        this.AddUserMessage("There is currently no ETA for P04 Write.");
                         this.AddUserMessage("**********************************************");
                     }
                 }
@@ -1234,9 +1233,9 @@ private async void readFullContents_BackgroundThread()
 
                     if (pcmInfo.HardwareType == PcmType.P04)
                     {
-                        this.AddUserMessage("WARNING: P04 Read is EXPERIMENTAL ONLY.");
-                        this.AddUserMessage("It may or may not read your P04 correctly. The read will be VERY SLOW.");
-                        DialogResult dialogResult = MessageBox.Show("WARNING: P04 Read is EXPERIMENTAL ONLY.\nIt may or may not read your P04 correctly.\nThe read will be VERY SLOW.\n", "Continue?", MessageBoxButtons.YesNo);
+                        this.AddUserMessage("WARNING: P04 Support i still in development.");
+                        this.AddUserMessage("It may or may not read your P04 correctly.");
+                        DialogResult dialogResult = MessageBox.Show("WARNING: P04 Read is still in development.\nIt may or may not read your P04 correctly.\n", "Continue?", MessageBoxButtons.YesNo);
                         if (dialogResult == DialogResult.No)
                         {
                             this.AddUserMessage("User chose not to proceed");

diff --git a/Apps/PcmLibrary/Devices/ScanToolDeviceImplementation.cs b/Apps/PcmLibrary/Devices/ScanToolDeviceImplementation.cs
@@ -109,11 +109,9 @@ public override async Task<bool> Initialize()
                 }
                 else
                 {
-                    this.Logger.AddUserMessage("This ScanTool device is not supported.");
-                    this.Logger.AddUserMessage("Please check pcmhammer.org to ensure that you have the latest release.");
-                    this.Logger.AddUserMessage("We're going to default to very small packet sizes, which will make everything slow, but at least it'll probably work.");
-                    this.MaxSendSize = 128 + 12;
-                    this.MaxReceiveSize = 128 + 12;
+                    this.Logger.AddUserMessage("This ScanTool device is not confirmed to work with 1K packets.");
+                    this.MaxSendSize = 1024 + 12;
+                    this.MaxReceiveSize = 1024 + 12;
                 }
 
                 // Setting timeout to a large value. Since we use STPX commands,