[WIP] Refine API #24
[WIP] Refine API #24
Conversation
- Refactored Test Class into function - Removed React from being a global variable
- Added babelrc - Split npm test into npm run mocha and npm run lint
elements can be accesed by this.elements
| middleware | ||
| no-dom.js | ||
| tests.js | ||
| lib |
There was a problem hiding this comment.
It still needs to output files to the root directory
There was a problem hiding this comment.
It does out to the root directory. When I switched branched, old lib folder stayed there and it was removed from gitignore So, I added it gitignore instead of deleting those lib files. I'll remove that line.
|
I really like this PR. Shall I close #23 and make a new one once this gets merged and we decide on an API for nested search? |
|
Okay this is super awesome! Really really like these improvements! I want to merge this badly! Can you just do two things: Add the mixin stuff to the readme and also add a test file for mixins. Then I'll be merging :) @geowarin I think you should do that. Thank you both for all your work!! |
|
Oh and make sure if you pass just a callback it still just grabs the first element |
| } | ||
|
|
||
| if (Object.keys(this.elements).length === 1) { | ||
| select.call(this, this.elements[Object.keys(this.elements)[0]]) |
There was a problem hiding this comment.
@zackify This line grabs the callback.
|
I want to do a bunch a little stuff before this gets I'll do it by tomorrow. |
|
What more do you want to wait on? |
|
@zackify Nevermind. I'll do it another PR. I kind of forgot what I wanted to do cuz I am a little busy until the weekend. I'll take a look on Friday again. |
|
👍 cant wait to use this! |
|
@vramana any updates? |
|
@zackify Merge this. I did the changes you asked for. I'll submit another PR tomorrow. |
| // In this example, CustomFind middleware was added to Test by mixin | ||
| // and used if as it was a method on Test itself. | ||
|
|
||
| Test(<TestComponent />) |
There was a problem hiding this comment.
would be cool to do something like Test.mixin at the top of your tests file or in a setup file and then have them available everywhere.
There was a problem hiding this comment.
I will do that in the next PR. I am really tired today! Had a long day!!
helpersuseas its obselete.