extension: Perform runtime-only settings overriding #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this as WIP given the gjs requirement... |
3v1n0
force-pushed
the
rewrite-settings-override
branch
from
de07e66
to
c4d402f
Compare
It can be useful to override behavior of classes and actors we do not control
3v1n0
force-pushed
the
rewrite-settings-override
branch
3 times, most recently
from
6a29f6a
to
91f57e7
Compare
The extension is overriding the user settings by writing on them, sadly this implies various issues because even if we reset them on extension unloading, a shell crash or mis-behavior could always lead to affect user settings. To prevent this, we can temporary override Settings backend read vfunc so that the values we want to override won't ever be written to user db and so there will be no risk of leaving them in a dirty state. Sadly, this requires fixes to gjs: https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/831
3v1n0
force-pushed
the
rewrite-settings-override
branch
from
91f57e7
to
9a1997b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension is overriding the user settings by writing on them, sadly this
implies various issues because even if we reset them on extension unloading,
a shell crash or mis-behavior could always lead to affect user settings.
To prevent this, we can temporary override Settings backend read vfunc so
that the values we want to override won't ever be written to user db and so
there will be no risk of leaving them in a dirty state.
Sadly, this requires fixes to gjs:
https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/831