Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use last_version_code_viewed rather than changelog_viewed for showing the changelog #1272

Closed
3 tasks done
dessalines opened this issue Nov 2, 2023 · 0 comments · Fixed by #1355
Closed
3 tasks done

Use last_version_code_viewed rather than changelog_viewed for showing the changelog #1272

dessalines opened this issue Nov 2, 2023 · 0 comments · Fixed by #1355
Assignees
@dessalines
Labels
enhancement New feature or request

Comments

@dessalines
Copy link
Member

Pre-Flight checklist

  • Did you check to see if this issue already exists?
  • This is a single feature request. (Do not put multiple feature requests in one issue)
  • This is not a question or discussion. (Use https://lemmy.ml/c/jerboa for that)

Describe The Feature Request Below

Rather than using the changelog_viewed column, and having to do a migration to reset it, we should use a last_version_code_viewed column, and update it after viewing the current version.

This can be copied from ThumbKey.
@dessalines dessalines added the enhancement New feature or request label Nov 2, 2023
@dessalines dessalines self-assigned this Nov 2, 2023
@dessalines dessalines changed the title Use dynamic Changelog fetching Use last_version_code_viewed rather than changelog_viewed for showing the changelog Nov 2, 2023
dessalines added a commit that referenced this issue Feb 8, 2024
@dessalines
Adding a locally generated changelog.
478c7f9 
- Adds a last_version_code_viewed, that gets updated in the DB,
  and compared against the current version to show the changelog.
  This means we never have to manually update that column again.
- Add a generate_changelog.sh script that uses git-cliff. It copies
  the changelog into code assets, which can be done before the release.
- Fixes #1272
@dessalines dessalines mentioned this issue Feb 8, 2024
Merged
dessalines added a commit that referenced this issue Feb 9, 2024
@dessalines
Adding a locally generated changelog. (#1355)
d91a0d2 
* Adding a locally generated changelog.

- Adds a last_version_code_viewed, that gets updated in the DB,
  and compared against the current version to show the changelog.
  This means we never have to manually update that column again.
- Add a generate_changelog.sh script that uses git-cliff. It copies
  the changelog into code assets, which can be done before the release.
- Fixes #1272

* Removing 27 schema

* Removing 27 schema 2

* Moving changelog fetching to viewModel.
dessalines added a commit that referenced this issue Feb 12, 2024
@dessalines @MV-GH @Snow4DV
Adding registration applications queue. (#1339)
818f008 
* Starting to work on registration applications.

* Remove ImmutableList and add stability config file (#1342)

* Adding admin / mod view votes. (#1331)

* Starting to work on admin_view_votes, needs API added yet.

* Finished up adding admin view votes.

* Fix package name.

* Upping lemmy-api version.

* Adding a moderation subfield to post and comment action dropdowns.

* Adding feature flag check.

* Addressing PR comments.

- Moving padding up to Box.
- Using alternate feature flag method.

* Temp workaround for compose-settings height bug. (#1345)

- See alorma/Compose-Settings#203
- Fixes #1338

* Swipe post/comment to upvote/downvote/reply/save (#1327)

* SwipeToAction composable

* Swipe to downvote/upvote feature implemented with preset-based customization

* Fix kotlin format

* fix string resource

* Do not use SwipeToAction when it is disabled

* Improve scrolling experience

* Increase color shift animation speed

* Improve ranges

* new preset: only votes

* fix deltas & rename resources

* SwipeToAction implemented correctly, SwipeToDismiss replaced with SwipeToDismissBox, fixed swipe ranges

* Kotlin format

* use ordinal of enum in AppDB instead of int

* Fixed behaviour when downvotes disables/when not logged in

* Fix formatting

* Remove default param for enableDownVotes in SwipeToAction

* Fix colors for swipe actions

* Fixed lambda caching in rememberSwipeActionState

* Format kotlin

---------

Co-authored-by: Dessalines <dessalines@users.noreply.github.com>

* Almost finished viewmodel.

* A few more additions.

* Finishing up registration applications.

* Adding a locally generated changelog.

- Adds a last_version_code_viewed, that gets updated in the DB,
  and compared against the current version to show the changelog.
  This means we never have to manually update that column again.
- Add a generate_changelog.sh script that uses git-cliff. It copies
  the changelog into code assets, which can be done before the release.
- Fixes #1272

* Removing 27 schema

* Removing 27 schema 2

* Moving changelog fetching to viewModel.

* Persisting admin and mod status to DB.

* Fixing format.

* Removing weird changes.

* Don't display bottomNav until acc loads

* Fix formatting

* Fix swapToAnon invalidating jwt + fix navbar not showing for anon

---------

Co-authored-by: Maarten Vercruysse <67873169+MV-GH@users.noreply.github.com>
Co-authored-by: Mikhail Loginov <32912696+Snow4DV@users.noreply.github.com>
Co-authored-by: maarten.vercruysse <maarten.vercruysse@outlook.be>
dessalines added a commit that referenced this issue Feb 14, 2024
@dessalines @MV-GH @Snow4DV
Add report queue (#1360)
9ee80b4 
* Starting to work on registration applications.

* Remove ImmutableList and add stability config file (#1342)

* Adding admin / mod view votes. (#1331)

* Starting to work on admin_view_votes, needs API added yet.

* Finished up adding admin view votes.

* Fix package name.

* Upping lemmy-api version.

* Adding a moderation subfield to post and comment action dropdowns.

* Adding feature flag check.

* Addressing PR comments.

- Moving padding up to Box.
- Using alternate feature flag method.

* Temp workaround for compose-settings height bug. (#1345)

- See alorma/Compose-Settings#203
- Fixes #1338

* Swipe post/comment to upvote/downvote/reply/save (#1327)

* SwipeToAction composable

* Swipe to downvote/upvote feature implemented with preset-based customization

* Fix kotlin format

* fix string resource

* Do not use SwipeToAction when it is disabled

* Improve scrolling experience

* Increase color shift animation speed

* Improve ranges

* new preset: only votes

* fix deltas & rename resources

* SwipeToAction implemented correctly, SwipeToDismiss replaced with SwipeToDismissBox, fixed swipe ranges

* Kotlin format

* use ordinal of enum in AppDB instead of int

* Fixed behaviour when downvotes disables/when not logged in

* Fix formatting

* Remove default param for enableDownVotes in SwipeToAction

* Fix colors for swipe actions

* Fixed lambda caching in rememberSwipeActionState

* Format kotlin

---------

Co-authored-by: Dessalines <dessalines@users.noreply.github.com>

* Almost finished viewmodel.

* A few more additions.

* Finishing up registration applications.

* Adding a locally generated changelog.

- Adds a last_version_code_viewed, that gets updated in the DB,
  and compared against the current version to show the changelog.
  This means we never have to manually update that column again.
- Add a generate_changelog.sh script that uses git-cliff. It copies
  the changelog into code assets, which can be done before the release.
- Fixes #1272

* Removing 27 schema

* Removing 27 schema 2

* Adding the admin / mod report queue.

* Moving changelog fetching to viewModel.

* Persisting admin and mod status to DB.

* Fixing format.

* Removing weird changes.

* Missed formatting.

* Forgot to remove unused block.

* Fixing missing fullBody.

* Addressing PR comments.

---------

Co-authored-by: Maarten Vercruysse <67873169+MV-GH@users.noreply.github.com>
Co-authored-by: Mikhail Loginov <32912696+Snow4DV@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dessalines dessalines

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a locally generated changelog. LemmyNet/jerboa
1 participant
@dessalines