Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab font size too small #1403

Closed
rottenwheel opened this issue Feb 25, 2024 · 7 comments · Fixed by #1452
Closed

Tab font size too small #1403

rottenwheel opened this issue Feb 25, 2024 · 7 comments · Fixed by #1452
Assignees
Labels
bug Something isn't working

Comments

@rottenwheel
Copy link

Jerboa Version

0.0.60

Android Version + Phone

Android 14, Google Pixel 7

Describe The Bug

Font size of about, posts and comments tabs in the profile section is considerably smaller than in previous versions. Almost can't see it.

Applies to tabs across the board, in messages too.

Notified you of this on Lemmy, opening the issue as per your request. Thanks for all the great work.

To Reproduce

Just run v0.0.60 and pay attention to tabs font size.

In the case of a crash or when relevant include the logs

No response

@rottenwheel rottenwheel added the bug Something isn't working label Feb 25, 2024
@MV-GH
Copy link
Collaborator

MV-GH commented Feb 25, 2024

How it looked before:

image

How it looks now

image

By default tabs use this preset = TypographyKeyTokens.TitleSmall

Now:
The default_font_size is 16px, for title small it reduces this by 7px, so 9px
Previously it did 16px * 0.8 = 12.8px

Currently it makes titleSmall the same size as bodySmall?

I don't think this is wanted behaviour.

Actually all labels/headline/body/title have the same fontsize for their sizing (small/medium/large)

dessalines added a commit that referenced this issue Feb 25, 2024
@MV-GH
Copy link
Collaborator

MV-GH commented Feb 25, 2024

Compose default in SP Jerboa default in Px
headlineLarge 32 16
headlineMedium 28 13
headlineSmall 24 9
titleLarge 22 16
titleMedium 16 13
titleSmall 14 9
bodyLarge 16 16
bodyMedium 14 13
bodySmall 12 9
labelLarge 14 16
labelMedium 12 13
labelSmall 11 9
displayLarge 57 x
displayMedium 45 x
displaySmall 36 x

@dessalines
Copy link
Member

Its tough for us, because I can't find a good "official" way to do this using a custom base font size. This is the method I'm currently using in Type.kt

https://egeniq.com/blog/dynamic-font-sizes-with-jetpack-compose/

@dessalines
Copy link
Member

Another point for us, is that Headlines in jetpack compose (for us, only used by the post title) look giant. I have a few other lemmy apps installed, and most of them use only a slightly larger post title.

@MV-GH
Copy link
Collaborator

MV-GH commented Feb 25, 2024

Headliens is rarely usd anyway. So that one doesn't bother me. But we should do label/body/Title somewhat right ratios

@MV-GH
Copy link
Collaborator

MV-GH commented Mar 6, 2024

Is there a reason we originally used pixels instead of DP ?

The default is the size you want comment/post be? By default 16 pixels size refers to comments/posts body will have that size?

@dessalines
Copy link
Member

iirc we originally used pixels because our last markdown library had some weird custom sizing issues. Anyways sp are the preferred font size units now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants