Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry button when loading more posts fails #1209

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Sep 1, 2023

This should provide a better UX than scrolling up and down again to initiate another attempt. The only thing I am not sure of is that should we auto scroll to that button? Most time it appears behind the bottom nav and only visible upon scrolling up.

YD1GONWFd5

Fixes #806
Fixes #1003

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx!

.fillMaxWidth()
.padding(horizontal = XXL_PADDING),
onClick = onClick,
colors = ButtonDefaults.buttonColors(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just to force it as an error color.

@dessalines dessalines enabled auto-merge (squash) September 4, 2023 18:55
@dessalines dessalines merged commit 85a18bf into LemmyNet:main Sep 4, 2023
1 check passed
@MV-GH MV-GH deleted the feat/posts_failed_load_btn branch September 20, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants