Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chris banes compose-bom. #1530

Merged
merged 1 commit into from
May 31, 2024
Merged

Use chris banes compose-bom. #1530

merged 1 commit into from
May 31, 2024

Conversation

dessalines
Copy link
Member

context: #1502 (comment)

@dessalines dessalines requested a review from MV-GH as a code owner May 31, 2024 01:36

val composeBom = platform("dev.chrisbanes.compose:compose-bom:2024.05.00-alpha03")
implementation(composeBom)
implementation("androidx.activity:activity-compose")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming only the androidx. namespace things can use this composeBom.

I tried to do it with all of them at first, but some still required explicit versioning.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that only the libraries listed where were covered
https://developer.android.com/develop/ui/compose/bom/bom-mapping

But that is not case. So I am not sure, you can probably look at the dependencies of the BOM to find out. Which libs are covered.

Copy link
Collaborator

@MV-GH MV-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check one more thing once this is merged

since material3 alpha brings some behavioral changes to ExposedDrownMenu
image

This version also brings improvements to pullToRefresh which is a M3 version of pullRefresh we currently use. This is probably one of the last m1 we use.


val composeBom = platform("dev.chrisbanes.compose:compose-bom:2024.05.00-alpha03")
implementation(composeBom)
implementation("androidx.activity:activity-compose")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that only the libraries listed where were covered
https://developer.android.com/develop/ui/compose/bom/bom-mapping

But that is not case. So I am not sure, you can probably look at the dependencies of the BOM to find out. Which libs are covered.

@dessalines
Copy link
Member Author

According to their setup instructions, it looks like I got em all.

@dessalines dessalines merged commit 544ee98 into main May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants