Add deeplinks for createPost #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested changes
Jul 5, 2022
app/src/main/java/com/jerboa/ui/components/post/create/CreatePostActivity.kt
Show resolved
Hide resolved
That would be ideal. but we can't determine what is title and url from plain text, only whether the text is a url or not |
LunaticHacker
commented
Jul 6, 2022
app/src/main/java/com/jerboa/ui/components/post/create/CreatePost.kt
Outdated
Show resolved
Hide resolved
dessalines
reviewed
Jul 6, 2022
dessalines
reviewed
Jul 6, 2022
dessalines
requested changes
Jul 7, 2022
app/src/main/java/com/jerboa/ui/components/common/PictrsImage.kt
Outdated
Show resolved
Hide resolved
| @@ -152,6 +153,24 @@ fun PickImage( | |||
| mutableStateOf<Bitmap?>(null) | |||
| } | |||
|
|
|||
| if (image != null) { | |||
There was a problem hiding this comment.
God I hate kotlin null safety. Rust options are so much better.
|
Oops I forgot one more thing: make sure when doing a URL share, that it tries to fetch the post title |
LunaticHacker
force-pushed
the
share_to
branch
2 times, most recently
from
bfd49a4
to
e170807
Compare
* use existing regex from Android.Utils.Patterns to match urls * trigger onChangeurl initially to fetch suggested title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #163,
we should be able to handle sharing images too but i don't understand how the PickImage thing works :)