New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag for Lemmy 0.19.2 #215
Comments
0.19.3 at this point |
the tags are there (now, not sure about before), but they're not promoted to github releases |
I believe he's referring to the 1.3.1 tag. It got tagged before the VERSION file got bumped to the latest release, so it's behind. @ticoombs can you retroactively include/update that in the tagged release? What is the best way to handle this? IIRC, it got bumped a day or two after 1.3.1. In that case would we do 1.3.2 anyway? |
Side point, but that Is that the right way to handle it, or should I be doing it differently since we do tagged releases here? |
I think every time you update the VERSION, it should be followed by a new tag also. So 1.3.1 in this repo would be VERSION 0.19.1 of Lemmy, 1.3.2 would be VERSION 0.19.2 and so on. Then it's possible to easily go back to previous version (unless there has been database upgrades between versions, which should be highlighted in the release notes). |
Updating the VERSION file is fine, but creating the TAG is what causes the problem when people run The reasoning behind the 1.x vs 0.x tagging is because we (lemmy-ansible) also have to include upgrade notes and we didn't want to re-push versions, and the lemmy versions don't make sense when a system also contains ~4 other applications. If you could not automatically create the tag @dessalines for lemmy-ansible that would solve the confusion. <3
@codyro You don't retroactively update the tags/versions, you push a new one. You are correct if the VERSION gets updated we need to also push a new tag/release.
|
I really appreciate yalls help in handling these releases. |
@dessalines Is it possible to not tag the new releases for lemmy-ansible? That will avoid future issues & clashes with the tags/releases. Updating Thanks. |
Sure, I'll remove that part from our lemmy deploy script now. |
Deploying the main version gets us 0.19.2 of Lemmy but just needs a tag added here in the repo as well.
The text was updated successfully, but these errors were encountered: