Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: noqa on linelength for automated checks #186

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: noqa on linelength for automated checks #186

merged 1 commit into from
Oct 9, 2023

Conversation

ticoombs
Copy link
Collaborator

@ticoombs ticoombs commented Oct 9, 2023

closes #184

@ticoombs ticoombs added this to the 1.2.1 milestone Oct 9, 2023
@ticoombs ticoombs marked this pull request as ready for review October 9, 2023 06:51
@ticoombs ticoombs self-assigned this Oct 9, 2023
@ticoombs ticoombs mentioned this pull request Oct 9, 2023
Merged
@ticoombs ticoombs changed the title fix: noqa on linelength for password imports fix: noqa on linelength for automated checks Oct 9, 2023
codyro
codyro approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@codyro codyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I've been busy!

@codyro codyro merged commit c130322 into main Oct 9, 2023
2 checks passed
@codyro codyro mentioned this pull request Oct 9, 2023
Closed
@dessalines
Copy link
Member

You're ahead of me, thx!

Its also because the alpine ansible-lint package appears to be lagging.

@ticoombs ticoombs deleted the ticoombs-patch-4 branch October 9, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyro codyro codyro approved these changes

@Nutomic Nutomic Awaiting requested review from Nutomic Nutomic is a code owner

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

Assignees

@ticoombs ticoombs

Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Fix ansible-lint issue on examples/vars.yml causing CI failure
3 participants
@ticoombs @dessalines @codyro