Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hide community. Fixes #183 #184

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

dessalines
Copy link
Member

No description provided.

@dessalines dessalines marked this pull request as ready for review September 18, 2023 22:09
Comment on lines +349 to +361
/**
* Hide a community from public view.
*
* `HTTP.PUT /community/hide`
*/
hideCommunity(form: HideCommunity) {
return this.#wrapper<HideCommunity, CommunityResponse>(
HttpType.Put,
"/community/hide",
form,
);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, a hidden community should only be visible to the instance it's local to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hides all posts / comments from hidden communities from Local and All, and any community listings. So only admins or ppl who know the url can go to it and subscribe.

"Hidden from public" seems like the easiest way to denote that, but I can change that if necessary.

@SleeplessOne1917 SleeplessOne1917 merged commit f439a7c into main Sep 18, 2023
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the add_community_hide branch February 26, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants