Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original int type info for number #188

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

MV-GH
Copy link
Contributor

@MV-GH MV-GH commented Sep 22, 2023

To prevent the loss of the original type information we annotate ints with this comment. So that consumers of these types can appropriately switch between float and int.

I can't fully finish this PR because I can't get lemmy running on my distro atm.

So could someone regen the types with this new script and finish this PR.

fixes #187

@TheBrokenRail
Copy link
Contributor

TheBrokenRail commented Sep 22, 2023

TBH this seems like it would make it harder to parse not easier. Especially since every number is an integer. Why not just add a comment to the README?

EDIT: I just read #187, apparently some numbers are floats.

@MV-GH
Copy link
Contributor Author

MV-GH commented Sep 22, 2023

It seems to have some other changes included too

@MV-GH MV-GH marked this pull request as ready for review September 22, 2023 23:22
@dessalines
Copy link
Member

This should come after #181

@SleeplessOne1917 SleeplessOne1917 merged commit e270d67 into LemmyNet:main Sep 26, 2023
1 check passed
@MV-GH MV-GH deleted the add_int_visibility branch September 26, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INQUIRY] Should we let the BigInts stay, instead of transforming them to number
4 participants