Fix: missing semantic css classes and html elements #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all pages have a main and aside element when a sidebar is present to facilitate custom theming. This does not impact the default behavior of the front.
0xAnansi
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
jsit
suggested changes
Jun 25, 2023
| @@ -22,7 +22,7 @@ import { | |||
| } from "@utils/helpers"; | |||
| import type { QueryParams } from "@utils/types"; | |||
| import { RouteDataResponse } from "@utils/types"; | |||
| import { Component, linkEvent } from "inferno"; | |||
| import { Component, RefObject, createRef, linkEvent } from "inferno"; | |||
There was a problem hiding this comment.
I'm not sure why this additional ref stuff is necessary?
There was a problem hiding this comment.
This was set in the app component for this page, so had to move it in this component to be able to link it in the "main" element that was moved from app to community.
This can only be set on main elements for some reason, or it will be considered an error.
This is used for the "skip to main content" feature.
dessalines
approved these changes
Jun 26, 2023
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 26, 2023
* lemmy/main: fix vote button alignment Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583)
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 26, 2023
* Fix: missing semantic css classes and html elements. Now all pages have a main and aside element when a sidebar is present to facilitate custom theming. This does not impact the default behavior of the front. * Fix: re-added communityref on main element --------- Co-authored-by: 0xAnansi <0xAnansi@omageni.com> Co-authored-by: Jay Sitter <jsit@users.noreply.github.com> Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 27, 2023
* Fix: missing semantic css classes and html elements. Now all pages have a main and aside element when a sidebar is present to facilitate custom theming. This does not impact the default behavior of the front. * Fix: re-added communityref on main element --------- Co-authored-by: 0xAnansi <0xAnansi@omageni.com> Co-authored-by: Jay Sitter <jsit@users.noreply.github.com> Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 27, 2023
* lemmy/main: fix vote button alignment partially revert change Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583) remove hook entirely chore(DX): Add prettier to eslint config for use with editors fix bug collapsing previews when voting fix: Remove unnecessary string interpolations fix: Remove unnecessary class fix: Remove unnecessary classes fix: Restore removed classes fix: Remove wrapping li's fix: Remove extraneous classes fix: Move things back to where they were chore: Separate post mod buttons into functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all pages have a main and aside element when a sidebar is present to facilitate custom theming. This does not impact the default behavior of the front.
Note: removedref={this.mainContentRef}from the div element since it was flagged as an error, can't see any impact but I don't know what it does in the first place.