Indicate valid and invalid fields in signup form #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dullbananas
requested review from
dessalines and
SleeplessOne1917
as code owners
alectrocute
reviewed
Jun 21, 2023
| @@ -144,7 +144,7 @@ export class Signup extends Component<any, State> { | |||
| registerForm() { | |||
| const siteView = this.state.siteRes.site_view; | |||
| return ( | |||
| <form onSubmit={linkEvent(this, this.handleRegisterSubmit)}> | |||
| <form class="was-validated" onSubmit={linkEvent(this, this.handleRegisterSubmit)}> | |||
There was a problem hiding this comment.
It causes fields to show a check mark or an red exclamation mark to indicate whether or not the value is valid
SleeplessOne1917
approved these changes
Jun 21, 2023
dessalines
requested changes
Jun 26, 2023
auto-merge was automatically disabled
June 26, 2023 19:28
Head branch was pushed to by a user without write access
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 26, 2023
* lemmy/main: fix vote button alignment Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583)
jsit
pushed a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 26, 2023
* Use was-validated class in signup form * Update signup.tsx * Update signup.tsx --------- Co-authored-by: SleeplessOne1917 <abias1122@gmail.com>
jsit
pushed a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 27, 2023
* Use was-validated class in signup form * Update signup.tsx * Update signup.tsx --------- Co-authored-by: SleeplessOne1917 <abias1122@gmail.com>
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 27, 2023
* lemmy/main: fix vote button alignment partially revert change Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583) remove hook entirely chore(DX): Add prettier to eslint config for use with editors fix bug collapsing previews when voting fix: Remove unnecessary string interpolations fix: Remove unnecessary class fix: Remove unnecessary classes fix: Restore removed classes fix: Remove wrapping li's fix: Remove extraneous classes fix: Move things back to where they were chore: Separate post mod buttons into functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1196