New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): Reduce base font size #1591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsit
requested review from
dessalines,
SleeplessOne1917 and
alectrocute
as code owners
June 25, 2023 18:46
alectrocute
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s hear from the other contributors before merging, but looks good to me.
SleeplessOne1917
approved these changes
Jun 25, 2023
dessalines
approved these changes
Jun 26, 2023
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 26, 2023
* lemmy/main: fix vote button alignment Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583)
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 26, 2023
* feat: Reduce base font size * chore: Build themes --------- Co-authored-by: SleeplessOne1917 <abias1122@gmail.com> Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 27, 2023
* feat: Reduce base font size * chore: Build themes --------- Co-authored-by: SleeplessOne1917 <abias1122@gmail.com> Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 27, 2023
* lemmy/main: fix vote button alignment partially revert change Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583) remove hook entirely chore(DX): Add prettier to eslint config for use with editors fix bug collapsing previews when voting fix: Remove unnecessary string interpolations fix: Remove unnecessary class fix: Remove unnecessary classes fix: Restore removed classes fix: Remove wrapping li's fix: Remove extraneous classes fix: Move things back to where they were chore: Separate post mod buttons into functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time. People seem to really not like how much space everything takes up. This could stand to be smaller, especially since so much of the text is UI, not body copy. The styles are responsive enough that people can zoom in and everything will work great.
Before
After