Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.18.0) Listing type on front page does not honor setting for non-logged in users #1612

Closed
4 tasks done
chenew opened this issue Jun 26, 2023 · 5 comments
Closed
4 tasks done
Labels
bug Something isn't working

Comments

@chenew
Copy link

chenew commented Jun 26, 2023

Requirements

  • This is a bug report, and if not, please post to https://lemmy.ml/c/lemmy_support instead.
  • Please check to see if this issue already exists.
  • It's a single bug. Do not report multiple bugs in one issue.
  • It's a frontend issue, not a backend issue; Otherwise please create an issue on the backend repo instead.

Summary

Since upgrading to 0.18.0, the listing type on the front page is defaulting to Local, even though the site setting is set to display All.

Set listing type to All in site setting:
image

What a non-logged in user sees:
image

Setting the listing type to 'All' helps smaller instances that may not have a lot of posts.

Steps to Reproduce

  1. In site setting, set the Listing Type setting to 'All'
  2. Visit the site as a non-logged in user
  3. The listing type will default to 'Local'
  4. Press F12 to bring up browser developer tools and hold the reload button to empty cache and hard reload

Technical Details

OS: Ubuntu 22.04
Browser: Tried on latest versions of Brave, Edge, Chrome

Lemmy Instance Version

0.18.0

Lemmy Instance URL

No response

@chenew chenew added the bug Something isn't working label Jun 26, 2023
@madeofstown
Copy link

Can confirm the same results with Firefox.

@delendum
Copy link

delendum commented Jul 1, 2023

Confirming this is still an issue in UI: 0.18.1-rc.7

@bdonvr
Copy link

bdonvr commented Jul 2, 2023

Yes, as a small instance admin this is quite frustrating. I imagine I (and possibly Lemmy as a whole) have lost a non-trivial amount of potential users because they thought the local feed was all that was going on Lemmy.

It seems @jcgurango solved this in an earlier version of Lemmy-UI, on a fork they made as a "hotfix". However the file they changed has been significantly updated and I don't have the skills to integrate their fix into latest. jcgurango@a360c9a

@jcgurango
Copy link
Contributor

@bdonvr just got around to updating my own small instance today (halubilo.social). I've made a docker image people can try out based on 0.18.1-rc.7 if they want: jcgurango/lemmy-ui:0.18.1-rc.7-hotfix and the code is up on the PR branch for those that wanna build it themselves.

dessalines pushed a commit that referenced this issue Jul 4, 2023
* Fix home page not using site-level listing type

* Use null handling instead
@chenew
Copy link
Author

chenew commented Jul 11, 2023

This is now fixed with 0.18.2 release. Thanks @jcgurango for the fix!

@chenew chenew closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants