Remove thumbnail expand icon on PostListing's postTitleLine
#1618
Conversation
alectrocute
requested review from
dessalines,
SleeplessOne1917 and
jsit
as code owners
Why wouldn't they? Isn't this only for image posts? Could be nice, rather than navigating to the domain where the image is hosted. |
|
I agree, image expanding isn't really necessary for link posts. But it is for image posts, as that's essentially one of the best utilities of RES. |
| @@ -482,26 +482,13 @@ export class PostListing extends Component<PostListingProps, PostListingState> { | |||
| this.postLink | |||
| )} | |||
| </h5> | |||
| {(url && isImage(url)) || | |||
| (post.thumbnail_url && ( | |||
There was a problem hiding this comment.
I think all that's necessary is to remove the or condition. We do want to show an expando for image posts, just not for link posts.
|
Should this be handled in #1596? I sense a conflict coming. |
|
I thought clicking the thumbnail is the expando for image posts? |
Oh yeah I forgot. In that case yep it makes sense to remove this. That'll help @jsit 's PR as it removes the conflicting icons. |
* lemmy/main: fix vote button alignment Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583)
Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
* lemmy/main: fix vote button alignment partially revert change Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583) remove hook entirely chore(DX): Add prettier to eslint config for use with editors fix bug collapsing previews when voting fix: Remove unnecessary string interpolations fix: Remove unnecessary class fix: Remove unnecessary classes fix: Restore removed classes fix: Remove wrapping li's fix: Remove extraneous classes fix: Move things back to where they were chore: Separate post mod buttons into functions
Hi Lemdevs!
In this PR:
PostListing'spostTitleLineThanks!