Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove websocket disconnect message #355

Closed
dessalines opened this issue Jul 31, 2021 · 2 comments
Closed

Remove websocket disconnect message #355

dessalines opened this issue Jul 31, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@dessalines
Copy link
Member

People really don't like it.
@dessalines dessalines added the enhancement New feature or request label Jul 31, 2021
@EchedelleLR
Copy link

Disconnect and reconnect.

I saw the second one with links to the same website.

@Nutomic
Copy link
Member

Nutomic commented Jul 31, 2021 •
edited
Loading

There are probably some cases where it would be useful, like the server going down or the user losing internet access. But in those cases it might also be better to show an error message when a websocket request fails.

dessalines added a commit that referenced this issue Jul 31, 2021
@dessalines
Remove websocket connection messages. Fixes #355
c875bea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dessalines @Nutomic @EchedelleLR