Totp change #2165
Merged
Totp change #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Oct 4, 2023
| }); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It looks really great, just wish we didn't have to rely on bootstrap modals, and so much custom dom manipulation.
There was a problem hiding this comment.
I did a bit of refactoring to make handling the modal a bit more react-like.
dessalines
approved these changes
Oct 5, 2023
|
I'll fix that and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an update so the UI works with the 2FA changes on the server side.
Screenshots
This is what shows when enabling 2FA:
enable_totp_demo.webm
This video shows using the new modal on the login screen:
totp_login_demo.webm
This video shows how the modal works when entering 1 character at a time and hitting backspace, as well as what happens when an incorrect token is entered:
totp_play_around.webm
TODO
Add translations