Adding cursor pagination. Fixes #2155 #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
SleeplessOne1917,
alectrocute and
jsit
as code owners
Comment on lines
37
to
45
| handlePrev(i: PaginatorCursor) { | ||
| i.props.onPrev(); | ||
| } | ||
|
|
||
| handleNext(i: PaginatorCursor) { | ||
| if (i.props.nextPage) { | ||
| i.props.onNext(i.props.nextPage); | ||
| } | ||
| } |
There was a problem hiding this comment.
Nitpick: these can be declared as regular functions instead of class methods since you are using linkEvent.
| prevPage?: PaginationCursor; | ||
| nextPage?: PaginationCursor; | ||
| onNext(val: PaginationCursor): any; | ||
| onPrev(): any; |
There was a problem hiding this comment.
We don't use what gets returned from this (if anything), so it could just return void.
| interface PaginatorCursorProps { | ||
| prevPage?: PaginationCursor; | ||
| nextPage?: PaginationCursor; | ||
| onNext(val: PaginationCursor): any; |
There was a problem hiding this comment.
Do we use the return value for this? If not, we could make this return void as well.
SleeplessOne1917
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds cursor pagination by adding a
pageCursorin place ofpagein the home and community urls.Since the API doesn't return a
previous_cursor, I had to use the back button for a previous, but it works well.This breaks next page comment pagination (the first page shows fine), but we should probably do away with those at some point anyway.