Fix parent comment linking when not showing context #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snan
force-pushed
the
main
branch
2 times, most recently
from
ab1cd11
to
c6b16b1
Compare
|
(Trying to figure out what the linter wants by trial and error.) |
snan
force-pushed
the
main
branch
2 times, most recently
from
01123eb
to
facb03e
Compare
The same code is reused for the "show context" button as for the "link to self" button. I'm not sure that's such a good idea in the long run. There was a const `parentCommentId` that was always set even when not having the `showContext` prop, causing the bug LemmyNet#2401.
|
(The last force push was just to get in up to date with y'alls main since you were hacking at the same time. Letting go now!) |
dessalines
approved these changes
Apr 11, 2024
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.
There was a const
parentCommentIdthat was always set even when nothaving the
showContextprop, causing the bug #2401.