Use muted display names, and always show instance for non-local. #1975 #2064 #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
approved these changes
Apr 16, 2024
| @@ -93,7 +76,10 @@ export class PersonListing extends Component<PersonListingProps, any> { | |||
| icon | |||
| /> | |||
| )} | |||
| <span>{displayName}</span> | |||
| <span>{name}</span> | |||
| {serverStr !== undefined && ( | |||
There was a problem hiding this comment.
Are there any falsey values you're trying to avoid matching?
Comment on lines
+43
to
+49
| const classes = classNames( | ||
| "person-listing d-inline-flex align-items-baseline", | ||
| { | ||
| "text-muted": this.props.muted, | ||
| "text-info": !this.props.muted, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
A ternary using muted would be more concise.
There was a problem hiding this comment.
This is using that special classNames function, it can't work in that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Everyone seems to like this one from jerboa anyway, so I'll add it here.
When its a non-local instance, always show the instance, but make it smaller and muted.
Screenshots
Before
Didn't show instance name if a display name was set
After
Always shows it (for non-local)
(ignore the localhost string, that's just for testing)