Render more while reloading only some resources #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`componentDidMount` is called after the first render. A lot of components used it to call `setState`, which causes a second render.
Not sure why this wasn't the case without this change. The only difference here is that the same array is reused in every render.
These used to (mostly) arrive at the old already unmounted components. Now they would render briefly until the latest response is received.
Comment on lines
18
to
22
| return ( | ||
| this.state.ellipses || ( | ||
| <span dangerouslySetInnerHTML={{ __html: " " }} /> | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Why the space is ellipses doesn't exist? And why use dangerouslySetInnerHTML for this?
There was a problem hiding this comment.
Modlog title collapses when it cycles to the empty string
Looks like <span> </span> does work. Thought i tried that. I'm moving it to modlog directly.
| @@ -64,7 +65,7 @@ export function SubscribeButton({ | |||
| > | |||
| {I18NextService.i18n.t("subscribe")} | |||
| </button> | |||
| <RemoteFetchModal communityActorId={actor_id} /> | |||
| <RemoteFetchModal show={false} communityActorId={actor_id} /> | |||
There was a problem hiding this comment.
Why is show hard-coded to false?
There was a problem hiding this comment.
Going to make it optional in modalMixin.
SleeplessOne1917
approved these changes
May 22, 2024
|
@matc-pub would you be willing to help with lemmy-ui PRs, and be a codeowner? It'd be much appreciated. |
|
I can give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change can keep components mounted when the next URL matches the current
route. This allows components to keep rendering some resources while reloading
others.
Commit ff5a391 contains most of the markup changes without running prettier, the follow up commit is only running prettier.
Changes
Home, Community
Post
/post/:post_id/:comment_id?(/comment/:comment_idstill works)Search
Modlog
Profile
Spinners
Prompt
Inbox
Other changes