Show deleted and removed posts for profile views. Fixes #2624

crates/apub/src/http/mod.rs

@@ -128,7 +128,7 @@ pub(crate) async fn get_activity(
 
   let sensitive = activity.sensitive.unwrap_or(true);
   if !activity.local {
-    return Err(err_object_not_local());
+    Err(err_object_not_local())
   } else if sensitive {
     Ok(HttpResponse::Forbidden().finish())
   } else {

crates/db_views/src/post_view.rs

@@ -349,7 +349,6 @@ impl<'a> PostQuery<'a> {
       );
     }
 
-    // If its for a specific person, show the removed / deleted
     if let Some(creator_id) = self.creator_id {
       query = query.filter(post::creator_id.eq(creator_id));
     }
@@ -382,6 +381,17 @@ impl<'a> PostQuery<'a> {
       query = query.filter(person_block::person_id.is_null());
     }
 
+    // If you are not logged in, or its not profile fetch, hide the removed / deleted
+    // TODO This should join to the post::creator_id column, in order to only hide posts for
+    // others, but diesel doesn't currently have case when support
+    if self.local_user.is_none() || self.creator_id.is_none() {
+      query = query
+        .filter(post::removed.eq(false))
+        .filter(post::deleted.eq(false))
+        .filter(community::removed.eq(false))
+        .filter(community::deleted.eq(false));
+    }
+
     query = match self.sort.unwrap_or(SortType::Hot) {
       SortType::Active => query
         .then_order_by(
@@ -424,13 +434,7 @@ impl<'a> PostQuery<'a> {
 
     let (limit, offset) = limit_and_offset(self.page, self.limit)?;
 
-    query = query
-      .limit(limit)
-      .offset(offset)
-      .filter(post::removed.eq(false))
-      .filter(post::deleted.eq(false))
-      .filter(community::removed.eq(false))
-      .filter(community::deleted.eq(false));
+    query = query.limit(limit).offset(offset);
 
     debug!("Post View Query: {:?}", debug_query::<Pg, _>(&query));