Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow the same user to necrobump their own thread. #1675

Closed
dessalines opened this issue Jul 27, 2021 · 2 comments · Fixed by #1683
Closed

Don't allow the same user to necrobump their own thread. #1675

dessalines opened this issue Jul 27, 2021 · 2 comments · Fixed by #1683
Labels
bug Something isn't working

Comments

@dessalines
Copy link
Member

Context

Lemmy's Active sort allow threads to be bumped for activity by commenting on them (limited up to 2 days). This is fine and its the purpose of it, but the post creators themselves should not be able to bump their own threads. "Activity", here really means community engagement, so that means other people.
@dessalines dessalines added the bug Something isn't working label Jul 27, 2021
@Nutomic
Copy link
Member

Nutomic commented Jul 27, 2021 •
edited

I understood the problem is that deleted comments are counted towards the total comment count. Imo they should be excluded (so if there is only one deleted comment on the post, it should show "0 comments").

@dessalines
Copy link
Member Author

Ahh, that is a separate thing then. I can open up one for that too.

dessalines added a commit that referenced this issue Aug 2, 2021
@dessalines
Some comment count fixes.
896ba84 
- Make sure an update to deleted decreases the count. Fixes #1676
- Don't allow the post creator to comment necro-bump their own post.
  Fixes #1675
@dessalines dessalines mentioned this issue Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some comment count fixes. LemmyNet/lemmy
2 participants
@dessalines @Nutomic