Blank out extra info for deleted or removed content. Fixes #1679 #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
commented
Jul 30, 2021
Comment on lines
+263
to
+276
| impl DeleteableOrRemoveable for Post { | ||
| fn blank_out_deleted_or_removed_info(mut self) -> Self { | ||
| self.name = "".into(); | ||
| self.url = None; | ||
| self.body = None; | ||
| self.embed_title = None; | ||
| self.embed_description = None; | ||
| self.embed_html = None; | ||
| self.thumbnail_url = None; | ||
|
|
||
| self | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the main thing, adding a trait for these types that allows you to blank out some fields.
dessalines
commented
Jul 30, 2021
Comment on lines
+158
to
+165
| // Blank out deleted or removed info | ||
| for pv in posts | ||
| .iter_mut() | ||
| .filter(|p| p.post.deleted || p.post.removed) | ||
| { | ||
| pv.post = pv.to_owned().post.blank_out_deleted_or_removed_info(); | ||
| } | ||
|
|
There was a problem hiding this comment.
The vector versions of these are a bit verbose, but I can't think of a good way to do them without using maybe another trait with an associated type.
|
Its certainly not the most elegant solution, and its easy to forget the blank_out call somewhere. I guess we could make these fields optional, or make a separate struct for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't particularly like this solution, as this blanking happens after the database calls, so requires some in-code manipulation, when I'd really rather have the DB be able to do it. But there's no way that I can think of to do that, IE blanking other columns if one is a certain result.
The vector looping if probably fast enough that it's not an issue.