Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide community from trending section #1980

Closed
dayinjing opened this issue Dec 7, 2021 · 6 comments
Closed

Hide community from trending section #1980

dayinjing opened this issue Dec 7, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@dayinjing
Copy link
Contributor

dayinjing commented Dec 7, 2021

For front end issues, use lemmy-ui

Is your proposal related to a problem?

(Sometimes I don't want to remove a community but I also don't want new users to see it on the front page.)

Describe the solution you'd like

(Allow admins to hide communities from trending section and also all.)

Describe alternatives you've considered

(Shadow ban it.)

Additional context

(Probably be good if the user who made it still sees it so they don't create a bunch of crap communities.)

Lets take for example Ruqqus, when MGTOW came to ruqqus the whole front trending page turned into divorced men complaining about life. It would be mean to not allow such people to have a space to help each other but people also don't want to see it when they first come to the site. If a user wants to search it up in the list and subscribe to it then it could show up in trending and all the same way.

This way a site admin can better control their front page without turning away communities entirely.

@dayinjing dayinjing added the enhancement New feature or request label Dec 7, 2021
@dayinjing
Copy link
Contributor Author

I'm ready to work on this now btw. Would just like a sign off from the main maintainers on a design.

Should we create a seperate end point for trending? should we make a new endpoint that gets a list of blacklisted communities and pass it to the community list endpoint?

@Nutomic
Copy link
Member

Nutomic commented Dec 8, 2021

I think there are a few ways that this could implemented, and the end result will depend on which one you pick. One option would be a new config option to hide communities, that would be pretty simple, and without changes in the api/frontend. It could be in the community settings, which means mods can also change it. Or it could be a separate table, and even changes on the frontend to hide/unhide communities.

Anyway it seems like an interesting and useful feature. Only problem might be if the feature is intransparent to people. So it might be necessary to indicate the hiding in some way. But in general i dont see any reason against merging something like this.

@dessalines
Copy link
Member

The easiest way to do would be to add an optional hidden_communities string array to the config... database-wise it wouldn't be optimal, because it'd require a not in( query. I don't like that too much.

The best DB wise would probably be a hidden column on the community table, default false. And then add a HideCommunity endpoint, and some way through the UI for admins to update that column. Then you'd only have to do .filter(community::hidden.eq(false)

@dayinjing
Copy link
Contributor Author

I think there are a few ways that this could implemented, and the end result will depend on which one you pick. One option would be a new config option to hide communities, that would be pretty simple, and without changes in the api/frontend. It could be in the community settings, which means mods can also change it. Or it could be a separate table, and even changes on the frontend to hide/unhide communities.

Anyway it seems like an interesting and useful feature. Only problem might be if the feature is intransparent to people. So it might be necessary to indicate the hiding in some way. But in general i dont see any reason against merging something like this.

I would like the community to be hidden from trending communities and all but still be shown in the community list. Maybe if it's really bad also have it not show up on the communities list but users can still see it if they are subscribed or enter in the url.

Maybe if that is to complicated we can just hide it from all of it for now. I'm ok with that.

@dayinjing
Copy link
Contributor Author

Initial PR for backend #2017

@dayinjing
Copy link
Contributor Author

Backend merged in PR #2055

Still need to Add stuff to UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants