Fixing release script. #3398
Merged
Fixing release script. #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
commented
Jun 28, 2023
scripts/release.sh
Outdated
| @@ -53,6 +52,8 @@ git tag $new_tag | |||
| git push origin $new_tag | |||
| git push | |||
|
|
|||
| popd | |||
There was a problem hiding this comment.
Without this, the git add crates/utils/translations was in the wrong location.
There was a problem hiding this comment.
So you execute the script from inside scripts/ folder? Seems like it would break if you run it from project root, would be good if it worked from both places (or throws an error if its the wrong working dir).
There was a problem hiding this comment.
Yep I always run scripts from their directory.
There was a problem hiding this comment.
I always run them from the root path. Please add the following lines so that both ways work:
Nutomic
reviewed
Jun 29, 2023
Nutomic
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.