Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing release script. #3398

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Fixing release script. #3398

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
911a037
Fixing release script.
dessalines Jun 28, 2023
7cb2915
Merge branch 'main' into fix_release_script_3
dessalines Jun 29, 2023
27462cb
Version 0.18.1-rc.2
dessalines Jun 29, 2023
86847d5
Removing cargo update from release script.
dessalines Jun 29, 2023
7f4e42b
Merge branch 'main' into fix_release_script_3
dessalines Jun 29, 2023
c3f9b40
Fixing topdir location.
dessalines Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ sed -i "s/version = \"$old_tag\"/version = \"$new_tag\"/g" Cargo.toml
git add Cargo.toml
cargo check
git add Cargo.lock
popd

# Update the submodules
git submodule update --remote
Expand All @@ -53,6 +52,8 @@ git tag $new_tag
git push origin $new_tag
git push

popd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, the git add crates/utils/translations was in the wrong location.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you execute the script from inside scripts/ folder? Seems like it would break if you run it from project root, would be good if it worked from both places (or throws an error if its the wrong working dir).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I always run scripts from their directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always run them from the root path. Please add the following lines so that both ways work:

https://github.com/LemmyNet/lemmy/pull/3389/files#diff-52afcc694c0ff8ff253441f42ff44d6b4734fe30ae9070f2ba07a668a10e7baaR4-R6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K done.


# Pushing to any ansible deploys
# cd ../../../lemmy-ansible || exit
# ansible-playbook -i prod playbooks/site.yml --vault-password-file vault_pass