Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posts with deleted comments can got into negative comment count #3501

Closed
4 tasks done
trashhalo opened this issue Jul 5, 2023 · 2 comments · Fixed by #3543
Closed
4 tasks done

Posts with deleted comments can got into negative comment count #3501

trashhalo opened this issue Jul 5, 2023 · 2 comments · Fixed by #3543
Labels
bug Something isn't working

Comments

@trashhalo
Copy link

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

https://beehaw.org/post/967973
Screenshot_20230705-194956

I'm going to guess its because the one comment on this was deleted by the creator but now the comment count is negative.

Steps to Reproduce

Technical Details

Na

Version

0.18.1-rc.9

Lemmy Instance URL

Beehaw
@trashhalo trashhalo added the bug Something isn't working label Jul 5, 2023
@ubergeek77
Copy link

Same goes for deleting communities, my instance currently has "-2" communities.

I think this is a more general problem of, things that are being decremented don't have a boundary at 0, so this kind of stuff happens.

@pijuszczyk
Copy link
Contributor

I'm on it. There is a problem with was_removed_or_deleted() function. I'll create a PR soon.

pijuszczyk added a commit to pijuszczyk/lemmy that referenced this issue Jul 8, 2023
@pijuszczyk
Fix LemmyNet#3501 - Fix aggregation counts for elements removed and d…
fd7a777 
…eleted

Two bugs were found and fixed:
- previously elements removal and deletion were counted as two separate disappearances
- removing comments did not affect post aggregations
@pijuszczyk pijuszczyk mentioned this issue Jul 8, 2023
Merged
pijuszczyk added a commit to pijuszczyk/lemmy that referenced this issue Jul 8, 2023
@pijuszczyk
Fix LemmyNet#3501 - Fix aggregation counts for elements removed and d…
d870438 
…eleted

Two bugs were found and fixed:
- previously elements removal and deletion were counted as two separate disappearances
- removing comments did not affect post aggregations
dessalines pushed a commit that referenced this issue Jul 10, 2023
@pijuszczyk
Fix #3501 - Fix aggregation counts for elements removed and deleted (#…
9c2490d 
…3543)

Two bugs were found and fixed:
- previously elements removal and deletion were counted as two separate disappearances
- removing comments did not affect post aggregations
PawanHegde pushed a commit to PawanHegde/lemmy that referenced this issue Jul 10, 2023
@pijuszczyk @PawanHegde
Fix LemmyNet#3501 - Fix aggregation counts for elements removed and d…
3f58cdd 
…eleted (LemmyNet#3543)

Two bugs were found and fixed:
- previously elements removal and deletion were counted as two separate disappearances
- removing comments did not affect post aggregations
Nutomic added a commit that referenced this issue Jul 10, 2023
@PawanHegde @phiresky
@dessalines @rosenjcb @nixoye @dullbananas @Nutomic @SleeplessOne1917 @sunaurus @pijuszczyk
Fix #3366: Wrap plain-text error responses from the API in JSON (#3559)
ef9dc5d 
* Fix #3366: API does return plain HTML errors

* Fix Clippy errors

* Improve api response times by doing send_activity asynchronously (#3493)

* do send_activity after http response

* move to util function

* format

* fix prometheus

* make synchronous federation configurable

* cargo fmt

* empty

* empty

---------

Co-authored-by: Dessalines <dessalines@users.noreply.github.com>

* Updating `login.rs` with generic `incorrect_login` response. (#3549)

* Adding v0.18.1 and v0.18.0 release notes. (#3530)

* Update RELEASES.md (#3556)

added instruction to find the location of your docker directory (especially useful for those who used ansible since they never had to setup docker manually)

* Use async email sender (#3554)

* Upgrade all dependencies (#3526)

* Upgrade all dependencies

* as base64

* Adding phiresky to codeowners. (#3576)

* Error enum fixed (#3487)

* Create error type enum

* Replace magic string slices with LemmyErrorTypes

* Remove unused enum

* Add rename snake case to error enum

* Rename functions

* clippy

* Fix merge errors

* Serialize in PascalCase instead of snake_case

* Revert src/lib

* Add serialization tests

* Update translations

* Fix compilation error in test

* Fix another compilation error

* Add code for generating typescript types

* Various fixes to avoid breaking api

* impl From<LemmyErrorType> for LemmyError

* with_lemmy_type

* trigger ci

---------

Co-authored-by: SleeplessOne1917 <abias1122@gmail.com>

* Only update site_aggregates for local site (#3516)

* Fix #3501 - Fix aggregation counts for elements removed and deleted (#3543)

Two bugs were found and fixed:
- previously elements removal and deletion were counted as two separate disappearances
- removing comments did not affect post aggregations

* Use LemmyErrorType also make error_type compulsory

* Add missing import for jsonify_plain_text_errors

* Fix formatting

* Trying to make woodpecker run again

---------

Co-authored-by: phiresky <phireskyde+git@gmail.com>
Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
Co-authored-by: rosenjcb <rosenjcb@gmail.com>
Co-authored-by: nixoye <12674582+nixoye@users.noreply.github.com>
Co-authored-by: dullbananas <dull.bananas0@gmail.com>
Co-authored-by: Nutomic <me@nutomic.com>
Co-authored-by: SleeplessOne1917 <abias1122@gmail.com>
Co-authored-by: Sander Saarend <sander@saarend.com>
Co-authored-by: Piotr Juszczyk <74842304+pijuszczyk@users.noreply.github.com>
Nutomic pushed a commit that referenced this issue Jul 21, 2023
@pijuszczyk @Nutomic
Fix #3501 - Fix aggregation counts for elements removed and deleted (#…
c666d1b 
…3543)

Two bugs were found and fixed:
- previously elements removal and deletion were counted as two separate disappearances
- removing comments did not affect post aggregations
@wpuckering wpuckering mentioned this issue Jul 28, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3501 - Fix aggregation counts for elements removed and deleted pijuszczyk/lemmy
3 participants
@trashhalo @ubergeek77 @pijuszczyk