Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: 2FA bypass using password reset #3714

Closed
4 tasks done
into-the-v0id opened this issue Jul 24, 2023 · 1 comment · Fixed by #3715
Closed
4 tasks done

[Bug]: 2FA bypass using password reset #3714

into-the-v0id opened this issue Jul 24, 2023 · 1 comment · Fixed by #3715
Labels
area: auth bug Something isn't working

Comments

@into-the-v0id
Copy link
Contributor

into-the-v0id commented Jul 24, 2023 •
edited

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

Bug discovered by @yesbutnobutyesbutno@sh.itjust.works via https://lemmy.ml/post/2404075

If a user with 2FA enabled resets their password, they are automatically authenticated without 2FA challenge upon submitting the password reset form.

Steps to Reproduce

  1. register user
  2. enable 2fa
  3. logout
  4. reset password

Technical Details

no technical details

Version

BE 0.18.1-47-g13a866aeb

Lemmy Instance URL

No response
@into-the-v0id into-the-v0id added the bug Something isn't working label Jul 24, 2023
into-the-v0id added a commit to into-the-v0id/lemmy that referenced this issue Jul 24, 2023
@into-the-v0id
Dont authenticate user after successful password reset LemmyNet#3714
40b6274
@into-the-v0id into-the-v0id mentioned this issue Jul 24, 2023
Merged
@RocketDerp

This comment was marked as abuse.

Sign in to view
into-the-v0id added a commit to into-the-v0id/lemmy that referenced this issue Jul 25, 2023
@into-the-v0id
Dont authenticate user after successful password reset LemmyNet#3714
6987edb
into-the-v0id added a commit to into-the-v0id/lemmy that referenced this issue Jul 25, 2023
@into-the-v0id
Dont authenticate user after successful password reset LemmyNet#3714
967d9ff
dessalines added a commit that referenced this issue Jul 25, 2023
@into-the-v0id @dessalines
Dont authenticate user after successful password reset #3714 (#3715)
cf2229d 
Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
Nutomic pushed a commit that referenced this issue Jul 26, 2023
@into-the-v0id @dessalines @Nutomic
Dont authenticate user after successful password reset #3714 (#3715)
d9ae9bf 
Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: auth bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 2FA bypass via password reset into-the-v0id/lemmy
3 participants
@lionirdeadman @into-the-v0id @RocketDerp