Fix 2FA bypass via password reset #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into-the-v0id
requested review from
Nutomic,
dessalines and
phiresky
as code owners
into-the-v0id
force-pushed
the
bugfix/2fa-bypass-using-password-reset
branch
from
40b6274
to
6987edb
Compare
into-the-v0id
force-pushed
the
bugfix/2fa-bypass-using-password-reset
branch
from
6987edb
to
967d9ff
Compare
dessalines
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3714
This PR changes the behavior of the password reset endpoint, so that it wont authenticate the user after a successful password reset.
In order to not introduce braking changes, the password reset endpoint will still return a Login Response but now without a JWT. That way Lemmy UI will just redirect to unauthenticated home after a successful password reset.